patch for ConvexHull2D to publish PolygonStamped

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

patch for ConvexHull2D to publish PolygonStamped

Ryohei Ueda
Hi all

here i attached a patch to publish a geometry_msgs/PolygonStamped
message for ConvexHull2D in pcl_ros package.

I think it is good to publish polygon messages when i use ConvexHull2D
as a plane finder.

is it possible to merge this patch into pcl_ros?
if the patch violates pcl_ros design, please let me know better way...

thanks
-- ryohei

_______________________________________________
[hidden email] / http://pcl.ros.org
https://code.ros.org/mailman/listinfo/pcl-users

pcl_ros_polygon.png (549K) Download Attachment
pcl_ros_convex_hull.patch (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: patch for ConvexHull2D to publish PolygonStamped

Radu B. Rusu
Administrator
Ryohei-san,

Thanks for the patch. We didn't want to add another dependency on PolygonStamped in PCL, but I see no problem in adding
that for the nodelets in PCL_ROS.

We'll look at the patch and incorporate it until noon (PST). :)

Cheers,
Radu.


On 11/29/2010 02:17 AM, Ryohei Ueda wrote:

> Hi all
>
> here i attached a patch to publish a geometry_msgs/PolygonStamped
> message for ConvexHull2D in pcl_ros package.
>
> I think it is good to publish polygon messages when i use ConvexHull2D
> as a plane finder.
>
> is it possible to merge this patch into pcl_ros?
> if the patch violates pcl_ros design, please let me know better way...
>
> thanks
> -- ryohei
>
>
>
> _______________________________________________
> [hidden email] / http://pcl.ros.org
> https://code.ros.org/mailman/listinfo/pcl-users
_______________________________________________
[hidden email] / http://pcl.ros.org
https://code.ros.org/mailman/listinfo/pcl-users