findVTK macros needed!

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

findVTK macros needed!

Radu B. Rusu
Administrator
I don't know if I forgot to mention this or if we simply didn't figure it out when we release 0.4.2, but any package
that depends on pcl_visualization now has to include the following two macros in its CMakeLists.txt:

find_package (VTK REQUIRED)
include(${VTK_USE_FILE})


This is not really the way we're supposed to do things in ROS, because package <Foo> that depends on package
<pcl_visualization> now has to explicitly include those two VTK macros... instead of -I/-L being somehow exported by
<pcl_visualization>.

Before this change we used to have a <vtk> metapackage. However, because:

  * Ubuntu 10.04 comes with libvtk 5.2, so -I /usr/include/libvtk5.2
  * Ubuntu 10.10 comes with libvtk 5.4, so -I /usr/include/libvtk5.4

it became a mess to export these things from vtk/manifest.xml.


So bottom line is: use find_package/include in your package's CMakeLists.txt if you depend on pcl_visualization for now.

Any other solutions on our way to 1.0 are welcome!

--
Cheers,
Radu.

_______________________________________________
[hidden email] / http://pcl.ros.org
https://code.ros.org/mailman/listinfo/pcl-users
Reply | Threaded
Open this post in threaded view
|

Re: findVTK macros needed!

Radu B. Rusu
Administrator
And finally a fix!

= 0.4.3 () =
  * [pcl_visualization] fixing an issue with VTK exports which lead to 3rd party user packages needing to know and
explicitly import VTK (r33980)

Hopefully we can make the release today. This means that using <pcl_visualization> works again without the need to
explicitly import/declare:

find_package (VTK REQUIRED)
include (${VTK_USE_FILE})

in your package's CMakeLists.txt. Your package now only has to depend on <pcl_visualization>.

Cheers,
Radu.


On 11/16/2010 08:17 AM, Radu Bogdan Rusu wrote:

> I don't know if I forgot to mention this or if we simply didn't figure it out when we release 0.4.2, but any package
> that depends on pcl_visualization now has to include the following two macros in its CMakeLists.txt:
>
> find_package (VTK REQUIRED)
> include(${VTK_USE_FILE})
>
>
> This is not really the way we're supposed to do things in ROS, because package <Foo> that depends on package
> <pcl_visualization> now has to explicitly include those two VTK macros... instead of -I/-L being somehow exported by
> <pcl_visualization>.
>
> Before this change we used to have a <vtk> metapackage. However, because:
>
> * Ubuntu 10.04 comes with libvtk 5.2, so -I /usr/include/libvtk5.2
> * Ubuntu 10.10 comes with libvtk 5.4, so -I /usr/include/libvtk5.4
>
> it became a mess to export these things from vtk/manifest.xml.
>
>
> So bottom line is: use find_package/include in your package's CMakeLists.txt if you depend on pcl_visualization for now.
>
> Any other solutions on our way to 1.0 are welcome!
>
_______________________________________________
[hidden email] / http://pcl.ros.org
https://code.ros.org/mailman/listinfo/pcl-users