API changes concerning SAC models, plus new SAC model

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

API changes concerning SAC models, plus new SAC model

Nico Blodow-2
Hi all,

in preparation for Diamondback 1.0 PCL release we have made the API a
bit more consistent. This might break your existing code, for which we
apologize, but it's a good change that will make different SAC model
types more aptly named.

Specifically, SAC_MODEL_ORIENTED_LINE is now SAC_MODEL_PARALLEL_LINE,
and SAC_MODEL_ORIENTED_PLANE is SAC_MODEL_PERPENDICULAR_PLANE.

Also, there is a new SAC_MODEL_PARALLEL_PLANE model that looks for
planes that are parallel to a user-given axis. This addition kind of
made the renaming necessary.

Cheers,
  -- Nico
_______________________________________________
[hidden email] / http://pcl.ros.org
https://code.ros.org/mailman/listinfo/pcl-users
Reply | Threaded
Open this post in threaded view
|

Re: API changes concerning SAC models, plus new SAC model

Radu B. Rusu
Administrator
Btw, I wonder whether we should release PCL only in unstable from now on, to avoid breaking the API of CTurtle users
even more.

We already provide instructions on how to use an overlay of trunk with rosinstall at
http://www.ros.org/wiki/point_cloud_perception.

Is everyone ok with this, or do people prefer to see these changes in the cturtle release, even if we modify the API
slightly as we work on improving/stabilizing PCL?

Cheers,
Radu.


On 09/26/2010 12:36 PM, Nico Blodow wrote:

> Hi all,
>
> in preparation for Diamondback 1.0 PCL release we have made the API a
> bit more consistent. This might break your existing code, for which we
> apologize, but it's a good change that will make different SAC model
> types more aptly named.
>
> Specifically, SAC_MODEL_ORIENTED_LINE is now SAC_MODEL_PARALLEL_LINE,
> and SAC_MODEL_ORIENTED_PLANE is SAC_MODEL_PERPENDICULAR_PLANE.
>
> Also, there is a new SAC_MODEL_PARALLEL_PLANE model that looks for
> planes that are parallel to a user-given axis. This addition kind of
> made the renaming necessary.
>
> Cheers,
>    -- Nico
> _______________________________________________
> [hidden email] / http://pcl.ros.org
> https://code.ros.org/mailman/listinfo/pcl-users
_______________________________________________
[hidden email] / http://pcl.ros.org
https://code.ros.org/mailman/listinfo/pcl-users
Reply | Threaded
Open this post in threaded view
|

Re: API changes concerning SAC models, plus new SAC model

Jack O'Quin
On Sun, Sep 26, 2010 at 2:57 PM, Radu Bogdan Rusu <[hidden email]> wrote:
> Btw, I wonder whether we should release PCL only in unstable from now on, to avoid breaking the API of CTurtle users
> even more.

If there are API changes, the answer is probably "yes".

The whole point of a release is to keep the API stable and just fix bugs.
--
 joq
_______________________________________________
[hidden email] / http://pcl.ros.org
https://code.ros.org/mailman/listinfo/pcl-users
Reply | Threaded
Open this post in threaded view
|

Re: API changes concerning SAC models, plus new SAC model

Radu B. Rusu
Administrator
Ok, we'll do that. Initially, the only reason why we were allowed to break the API is because we classified ourselves as
a "research stack", and we were planning to iterate fast to find the best set of methods, best API, etc. No reason to
lock it down before 1.0.

A lot more people use PCL now, so it makes sense to stop CTurtle releases. How's this?

(from http://www.ros.org/wiki/point_cloud_perception)

"
Users
-----

The latest revision of point_cloud_perception in CTurtle is 0.3.1. All releases after 0.3.1 are dealing with API
changes, and therefore are only released in Unstable.

If you're interested in staying up-to-date with the latest version of PCL, use the following rosinstall file: Currently,
point_cloud_perception is a very active stack with lots of updates happening on a daily basis. Though not recommended,
if you are a developer, and want to provide a patch, change something in the latest revision, or simply check if a bug
in the released version got fixed already, you can use the following rosinstall file:

- svn:
     uri: https://code.ros.org/svn/ros-pkg/stacks/point_cloud_perception/tags/unstable
     local-name: ros_pkg/stacks/point_cloud_perception


Developers
----------
Currently, point_cloud_perception is a very active stack with lots of updates happening on a daily basis. Though not
recommended, if you are a developer, and want to provide a patch, change something in the latest revision, or simply
check if a bug in the released version got fixed already, you can use the following rosinstall file:


- svn:
     uri: https://code.ros.org/svn/ros-pkg/stacks/point_cloud_perception/trunk
     local-name: ros_pkg/trunk/point_cloud_perception
"


Cheers,
Radu.


On 09/26/2010 04:43 PM, Jack O'Quin wrote:
> On Sun, Sep 26, 2010 at 2:57 PM, Radu Bogdan Rusu<[hidden email]>  wrote:
>> Btw, I wonder whether we should release PCL only in unstable from now on, to avoid breaking the API of CTurtle users
>> even more.
>
> If there are API changes, the answer is probably "yes".
>
> The whole point of a release is to keep the API stable and just fix bugs.
_______________________________________________
[hidden email] / http://pcl.ros.org
https://code.ros.org/mailman/listinfo/pcl-users